Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Tom august updates to cass_coopmans_I #402

Merged
merged 25 commits into from
Aug 18, 2024
Merged

ENH: Tom august updates to cass_coopmans_I #402

merged 25 commits into from
Aug 18, 2024

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 7, 2024

No description provided.

@mmcky mmcky changed the title ENH: Tom august updates to lectures ENH: Tom august updates to case_coopmans_I Aug 7, 2024
@mmcky
Copy link
Contributor Author

mmcky commented Aug 7, 2024

@shizejin it looks like there is an execution issue on this branch (not producing the plot)

T = paths[0].size - 1

is paths defined?

@shizejin
Copy link
Member

shizejin commented Aug 7, 2024

Thanks @mmcky. I tried to replicate the execution error on my local machine, but it builds well. Could you see more details about the execution issue from the server to better understand what's going wrong?

The paths should be have been created by the line paths = shooting(pp, 0.2, 0.3, T=10) in the cell above, and Tom and I didn't touch anything about the shooting function in this PR. Maybe there is something wrong when calling the shooting function, but I am sure what's causing it.

@mmcky mmcky changed the title ENH: Tom august updates to case_coopmans_I ENH: Tom august updates to cass_coopmans_I Aug 16, 2024
Copy link

@mmcky
Copy link
Contributor Author

mmcky commented Aug 18, 2024

it appears there was a strange interaction with the build cache so a full build succeeds. Merging this now.

@mmcky mmcky merged commit 94e1f42 into main Aug 18, 2024
4 of 5 checks passed
@mmcky mmcky deleted the tom_august branch August 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants