-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ak2] Update to Transitions in an Overlapping Generations Model lecture #508
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Jiarui-ZH the execution error is in this code cell
with the following error Failed in nopython mode pipeline (step: nopython frontend) This error may have been caused by the following argument(s):
|
@Jiarui-ZH I see you have removed |
@mmcky I ran a test and found out there's almost no runtime difference between having and not having jit. I have spoken to John and he suggested to just remove it all together. |
Thanks @Jiarui-ZH. Are these functions used later in any jitted functions? |
@Jiarui-ZH there is still an execution error being reported to do with |
The If we are going to remove all the I am not sure about the decline in speed with such modification though, because calling minimizer from scipy seems costly to me. But I would agree to removing all the |
I had to revert back to the first commit because I stil had trouble resolving the problem and the codes got messy, I will keep working on this |
thanks @shizejin for your input here. @Jiarui-ZH I suspect the I propose we close this PR given there aren't a lot of editorial changes. Then you can open a PR on the new repo once we move this lecture. Is that OK @Jiarui-ZH? |
@mmcky @Jiarui-ZH Thanks a lot for the great dicussion and contribution for improving ak2. I am just checking in if there is anything I could help with this PR? :) |
thanks @shizejin -- I am going to close this PR now so we can migrate to the new lecture series. Then it would be great to get your input into this lecture. Thank you. |
Update to Transitions in an Overlapping Generations Model lecture basing on #491
Content
Code