-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Test Execution for Google Collab #441
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mmcky Seems like larger machine is not assigned to run the job. |
enabled larger runner for ubuntu
thanks @kp992 I have enabled |
Thanks @kp992 I have reconfigured |
This reverts commit b6c5bef.
This error is currently being reported
however this error doesn't show up if I use @kp992 any ideas? |
What if we install the latest version of pandas globally instead of installing in specific lecture? |
@mmcky Woaah!! It's green. |
lectures/inflation_history.md
Outdated
if Version(pd.__version__) < Version('2.1.4'): | ||
from importlib import reload | ||
if Version(pandas.__version__) < Version('2.1.4'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed now right?
Sure, I will check on this by tomorrow. |
@mmcky Actually, I am also facing some issues upon installing docker on my mac. Should we try it on our Linux VM that we have? I didn't want to play with it because John might be using it and maybe something could break.
There are frequent updates because of changing dependencies among the libraries. |
Hi @mmcky, I was able to pull the docker image and following the steps mentioned there, I tested locally and I get pandas |
We can do one thing. Let's just do a manual testing for a list of failing lectures(currently just one |
@kp992 I don't fully understand why reload is working on Google Collab and not in this action. From my inspection of the logs the main issue is |
From the logs: �[?25hRequirement already satisfied: six>=1.5 in /usr/local/lib/python3.10/dist-packages (from python-dateutil>=2.8.2->pandas==2.1.4) (1.16.0)
----- stdout -----
Installing collected packages: tzdata, pandas
Attempting uninstall: pandas
Found existing installation: pandas 1.5.3
----- stdout -----
Uninstalling pandas-1.5.3:
Successfully uninstalled pandas-1.5.3
----- stdout -----
�[31mERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
google-colab 1.0.0 requires pandas==1.5.3, but you have pandas 2.1.4 which is incompatible.�[0m�[31m
�[0mSuccessfully installed pandas-2.1.4 tzdata-2024.1
------------------ This shows though there was some dependency error, and pip was successfully able to install The actual error is coming from the below line which is [0;31mImportError�[0m Traceback (most recent call last)
�[0;32m<ipython-input-2-e9f1b8a0cfbd>�[0m in �[0;36m<cell line: 4>�[0;34m()�[0m
�[1;32m 4�[0m �[0;32mif�[0m �[0mVersion�[0m�[0;34m(�[0m�[0mpandas�[0m�[0;34m.�[0m�[0m__version__�[0m�[0;34m)�[0m �[0;34m<�[0m �[0mVersion�[0m�[0;34m(�[0m�[0;34m'2.1.4'�[0m�[0;34m)�[0m�[0;34m:�[0m�[0;34m�[0m�[0;34m�[0m�[0m
�[1;32m 5�[0m �[0mget_ipython�[0m�[0;34m(�[0m�[0;34m)�[0m�[0;34m.�[0m�[0msystem�[0m�[0;34m(�[0m�[0;34m'pip install pandas==2.1.4'�[0m�[0;34m)�[0m�[0;34m�[0m�[0;34m�[0m�[0m
�[0;32m----> 6�[0;31m �[0mreload�[0m�[0;34m(�[0m�[0mpandas�[0m�[0;34m)�[0m�[0;34m�[0m�[0;34m�[0m�[0m I checked some other repos who are also facing this similar issue when doing |
thanks @kp992 what I don't understand is why I can do it in Google Collab though. |
@kp992 given the discrepancies between the If there is a way to interact with |
Hmm, strange thing, when I tried today pulling the docker image from colab and getting a pip list on our linux server, I get |
Triggering the job again to see if it might have been updated recently. |
Hey @mmcky, I was right. Previously it was pandas |
good news - thanks for letting me know @kp992 so it looks like the docker public runtime releases lag the online version a bit but I think we can accept that. 👍 |
Yeah, looks good to me know. thanks @mmcky |
This PR adds
google collab
compatibility testing for the intro lecture seriesRelated to QuantEcon/meta#139.