Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add in warning directive #145

Merged
merged 2 commits into from
Jun 8, 2021
Merged

add in warning directive #145

merged 2 commits into from
Jun 8, 2021

Conversation

aadsouza
Copy link
Contributor

@aadsouza aadsouza commented Jun 8, 2021

No description provided.

@github-actions github-actions bot temporarily deployed to commit June 8, 2021 03:52 Inactive
@github-actions github-actions bot temporarily deployed to commit June 8, 2021 03:56 Inactive
@aadsouza aadsouza requested a review from wupeifan June 8, 2021 03:59
@aadsouza
Copy link
Contributor Author

aadsouza commented Jun 8, 2021

i think this one's merge ready

@aadsouza
Copy link
Contributor Author

aadsouza commented Jun 8, 2021

there is a "warning" in control flow https://quantecon.github.io/lecture-datascience.myst/python_fundamentals/control_flow.html but i'm not sure if we want the whole 3+ lines/paragraphs in the directive so i haven't included it

@aadsouza aadsouza mentioned this pull request Jun 8, 2021
Closed
@aadsouza aadsouza changed the title wip: add in warning directive add in warning directive Jun 8, 2021
@wupeifan
Copy link
Contributor

wupeifan commented Jun 8, 2021

It's fine, "a warning" is not really warning.
This one should be fine to merge, I think.

@wupeifan wupeifan merged commit d93e292 into main Jun 8, 2021
@wupeifan wupeifan deleted the warnings-patch branch June 8, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wupeifan wupeifan wupeifan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadsouza @wupeifan