-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup #144
Update setup #144
Conversation
@@ -38,12 +38,12 @@ For Windows users, we recommend installing for "just me" instead of "all users". | |||
|
|||
## Downloading the QuantEcon Data Science Lectures | |||
|
|||
To download the QuantEcon Data Science lectures, we use the `Clone` button on the toolbar | |||
as seen in the following image. | |||
To download the QuantEcon Data Science lectures, go to its [Github repo](https://github.com/QuantEcon/lecture-datascience.myst), click on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a download notebook button at the top right corner of the page. I think that means you can download a single notebook instead of going to the github repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think this part is to download the notebooks instead of the codes that generate the notebook, if I'm not mistaken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It downloads a single notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it is different from what we used to have. All what I mean is just we want to be clear...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this way (going to the Github repo) is fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, downloading the lecture notes needs to happen at th enotebook repo, not the source one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link is incorrect, and it must go to https://github.com/QuantEcon/lecture-datascience.notebooks
Also, make sure those are updated before we go live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, my bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wupeifan i believe the "download entire nb repo" will make a comeback soon QuantEcon/quantecon-book-theme#126
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then we can edit these instructions after that merge. Not in a hurry.
@@ -54,7 +54,7 @@ You can download the lectures through either **Github Desktop** or **Terminal**: | |||
**Github Desktop** (Mac/Windows only), recommended for most users. | |||
|
|||
1. Install [Github Desktop](https://desktop.github.com/). | |||
1. Click the "Open in Github Desktop" option in the clone button menu. It should open a Github | |||
1. Click the "Open with Github Desktop" option in the Code button menu. It should open a Github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now that button is gone? Do we still have it somewhere on the launchbar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the github button in the toolbar refers to a specific lecture in the repo. Here "open with Github Desktop" option in the code button menu refers to that option in the Github website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's different. We should clearly say that the button comes from the Github repo website. Before it was from the datascience pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added another step before it to specify doing it in the github repo.
And I believe the changes to troubleshooting is missing. Do we still need that one? Or we can delete most of them...? |
You're right. I removed the parts on JupyterHub, and left it blank to fill later with instructions of google Colab and BinderHub. |
The PR updated some instructions for local and cloud setup. Some screenshots changed. However, we may need more through instructions for
BinderHub
.