FIX: Update num_compositions
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyamad
reviewed
Dec 23, 2017
quantecon/gridtools.py
Outdated
| @@ -281,4 +281,4 @@ def num_compositions(m, n): | |||
|
|
|||
| """ | |||
| # docs.scipy.org/doc/scipy/reference/generated/scipy.misc.comb.html | |||
There was a problem hiding this comment.
Please update this commit as well.
oyamad
approved these changes
Dec 23, 2017
|
LGTM Do we need to update a requirements.txt or something like that to note that these changes require spicy >= 1.0? |
|
|
|
@sglyon most of our requirements files don't specify versions (so they should default to latest). But are you suggesting we should put |
|
@mmcky I don't think we need specify a version for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
scipy.special.combinstead ofscipy.misc.combasscipy.misc.combis deprecated in scipy 1.0.0.