-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix timing utility docstrings for tic toc tac #319
Conversation
The docstring are OK. Looking at these functions again made me think one might sometime want to not print the elapsed time. Could be either |
I agree - I think there could be some useful improvements to these functions such as suppressing output, adjusting units, choosing precision, etc. |
@natashawatkins : do you want to open an issue with the other improvements you can think of ? Then I'll close this PR as it is. |
No problem - done in #322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@mmcky : I did the merge but can't close the PR. What did you actually expect me to do ? |
@albop the PR appears to be closed :) |
OK thanks ! |
tac
andtoc
docstrings were incorrect.fixes #314