Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timing utility docstrings for tic toc tac #319

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 3, 2017

tac and toc docstrings were incorrect.

fixes #314

@mmcky mmcky requested a review from albop August 3, 2017 06:26
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.124% when pulling 27439cf on fix-timing-docstrings into a82ba69 on master.

@albop
Copy link
Contributor

albop commented Aug 6, 2017

The docstring are OK. Looking at these functions again made me think one might sometime want to not print the elapsed time. Could be either toc(verbose=False) or (like in Julia) toq. Does it sound useful ?

@natashawatkins
Copy link
Member

I agree - I think there could be some useful improvements to these functions such as suppressing output, adjusting units, choosing precision, etc.

@albop
Copy link
Contributor

albop commented Aug 6, 2017

@natashawatkins : do you want to open an issue with the other improvements you can think of ? Then I'll close this PR as it is.

@natashawatkins
Copy link
Member

No problem - done in #322

@albop albop merged commit 64d964c into master Aug 6, 2017
Copy link
Contributor

@albop albop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@albop
Copy link
Contributor

albop commented Aug 6, 2017

@mmcky : I did the merge but can't close the PR. What did you actually expect me to do ?

@natashawatkins
Copy link
Member

@albop the PR appears to be closed :)

@albop
Copy link
Contributor

albop commented Aug 6, 2017

OK thanks !

@oyamad oyamad deleted the fix-timing-docstrings branch November 27, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Tic/Tac/Toc Utility
4 participants