Fix NumbaWarning #195
Closed
Fix NumbaWarning #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as an independent function in nopython mode; see Issue #155
Use less memory
|
Let me withdraw this PR. I don't see why these warnings show up, and why only with Python 3, while I cannot reproduce them in my environment so far. I also don't know if we really need to fix them so as to the warnings to disappear. (I will issue another PR for the second commit.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix one of the Numba warnings shown e.g. in Travis CI 421.2, on
sample_without_replacement(although I haven't been able to reproduce the warning messages in my environment); see also #155.The warning says Arg 3 (
random_state) ofsample_without_replacementis not legal in nopython mode. So I took the loops out as an independent function in nopython mode.As a side effect, this should resolve item 2 in #170.