Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QuantEcon.next_k_array! in support_enumeration #80

Closed
wants to merge 1 commit into from
Closed

Use QuantEcon.next_k_array! in support_enumeration #80

wants to merge 1 commit into from

Conversation

monsij
Copy link
Contributor

@monsij monsij commented May 21, 2018

Closes Issue #70

I have replaced all instances of _next_k_array! with next_k_array! and _next_k_combination with k_array_rank .Both from QuantEcon.jl

@codecov-io
Copy link

codecov-io commented May 21, 2018

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files           6        6           
  Lines         468      468           
=======================================
  Hits          451      451           
  Misses         17       17
Impacted Files Coverage Δ
src/support_enumeration.jl 98.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506ea7d...36fbf3d. Read the comment docs.

@monsij
Copy link
Contributor Author

monsij commented May 21, 2018

Kindly review @oyamad

@oyamad
Copy link
Member

oyamad commented May 22, 2018

@monsij Thanks, but it is not what is meant in #70 (sorry for my poor explanation!).

Maybe it will be easier to see what the task really is by looking at the corresponding change QuantEcon/QuantEcon.py@a215f1f in the Python version. Could you take some time to look at that commit?

@monsij
Copy link
Contributor Author

monsij commented May 22, 2018

I'll get back to it once I understand it.Thanks @oyamad

@monsij
Copy link
Contributor Author

monsij commented May 22, 2018

I am closing the pull request as the changes made are wrong.

@monsij monsij closed this May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants