-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new data download
command to lean-cli for data retrieval
#447
Merged
Martin-Molinero
merged 53 commits into
QuantConnect:master
from
Romazes:feature-388-support-download-data-provider
May 1, 2024
Merged
Add new data download
command to lean-cli for data retrieval
#447
Martin-Molinero
merged 53 commits into
QuantConnect:master
from
Romazes:feature-388-support-download-data-provider
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove: not used path mount feat: const for download config key
remove: extra const
refactor: param target_path in set up csharp options feat: run download project
rename: local methods
refactor: encapsulate data download data runner in tests
This reverts commit 3c9b704.
rename: input command market/security-type refactor: add prompt msg helper remove: prompt use selection method
refactor: get_complete_lean_config without environment and algo_file remove: test, cuz we have used interactive input for user
feat: get access to inner support of data sources test: refactor by new format
11 tasks
Martin-Molinero
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new command,
data download
, to the lean-cli tool. This command facilitates downloading various data types such as Trade, Quote, and Open Interest from multiple Historical Data Providers like Polygon, Binance, Interactive Brokers, etc. The command supports different resolutions like tick, second, minute, hour, and day, as well as different security types depending on the support available from the Data Provider. The command invokes an executable app from Lean to perform the data download.Related Issue
#388
Related Pull Request
Motivation and Context
The motivation behind this feature is to enhance the user experience by providing an easy-to-use command for downloading different types of data required for developing trading algorithms in Lean. By incorporating this feature into lean-cli, users can effortlessly download data and proceed with algorithm development without needing to manually handle data retrieval from various providers.
How Has This Been Tested?
This feature has been thoroughly tested to ensure its functionality and reliability:
Additional manual test cases:
Interactive Brokers [Security type: Equity]
Result:
Binance [Security type: Crypto]
Result
FactSet [Security type: IndexOption]
Result:
Polygon [Security type: Equity]
Result:
IEX [Security type: Equity]
Result: [wrong resolution]
IEX [Security type: Equity]
Result
Coinbase Advanced Trade [Security type: Crypto]
Example of running
Run ⬇ and follow the on-screen instructions to select the Data Provider, Data Type, Resolution, Security Type, tickers, start date, and end date.
Run ⬇
Conclusion
The main goal of this feature is to be user-friendly and assist users in downloading various data types required for creating new trading algorithms in Lean. By providing a seamless data retrieval process, users can focus more on algorithm development and less on data management.