Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Improvements #429

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Minor Improvements #429

merged 1 commit into from
Feb 29, 2024

Conversation

Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented Feb 29, 2024

  • Minor adjustment so that optional configurations are requested to the user if they have no value in interactive mode, in non interactive will use the default value if any
  • Log configuration messages once
  • Add data purchase limit for optimization. Closes lean optimize doesn't accept --data-purchase-limit option #425

Related #428

Sanity tested running live deployments and optimizations

- Minor adjustment so that optional configurations are requested to the
  user if they have no value in interactive mode, in non interactive
  will use the default value if any
- Log configuration messages once
- Add data purchase limit for optimization
@Martin-Molinero Martin-Molinero merged commit 8b31b59 into master Feb 29, 2024
46 checks passed
@Martin-Molinero Martin-Molinero deleted the bug-optional-setting-handling branch February 29, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lean optimize doesn't accept --data-purchase-limit option
1 participant