Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty strings as default json module input values #370

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Allow empty strings as default json module input values #370

merged 3 commits into from
Oct 6, 2023

Conversation

jhonabreul
Copy link
Collaborator

@jhonabreul jhonabreul commented Oct 5, 2023 •
edited
Loading

Allow empty strings as default json module input values when they are marked as optional.

  • Empty values in the lean.json file will still be prompted each time the user tries to deploy a live algorithm locally in interactive mode.
  • In non-interactive mode, skipped optional values will be populated with their default values -- even if they are empty -- and the user will not be pormpted for them.

Martin-Molinero
Martin-Molinero approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit 5e62db1 into QuantConnect:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martin-Molinero Martin-Molinero Martin-Molinero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhonabreul @Martin-Molinero