rename: gdax|coinbase pro -> coinbase Advanced Trade (#394)

QuantConnect · Jan 5, 2024 · 609c22e · 609c22e
1 parent df6ee12
commit 609c22e
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 28 deletions.
diff --git a/README.md b/README.md
@@ -269,7 +269,7 @@ Usage: lean cloud live deploy [OPTIONS] PROJECT
   --notify-insights.
 
 Options:
-  --brokerage [Paper Trading|Interactive Brokers|Tradier|Oanda|Bitfinex|Coinbase Pro|Binance|Zerodha|Samco|Terminal Link|Trading Technologies|Kraken|TDAmeritrade|Bybit]
+  --brokerage [Paper Trading|Interactive Brokers|Tradier|Oanda|Bitfinex|Coinbase Advanced Trade|Binance|Zerodha|Samco|Terminal Link|Trading Technologies|Kraken|TDAmeritrade|Bybit]
                                   The brokerage to use
   --ib-user-name TEXT             Your Interactive Brokers username
   --ib-account TEXT               Your Interactive Brokers account id
@@ -293,11 +293,8 @@ Options:
                                   The environment to run in, Practice for fxTrade Practice, Trade for fxTrade
   --bitfinex-api-key TEXT         Your Bitfinex API key
   --bitfinex-api-secret TEXT      Your Bitfinex API secret
-  --gdax-api-key TEXT             Your Coinbase Pro API key
-  --gdax-api-secret TEXT          Your Coinbase Pro API secret
-  --gdax-passphrase TEXT          Your Coinbase Pro API passphrase
-  --gdax-use-sandbox [live|paper]
-                                  Whether the sandbox should be used
+  --coinbase-api-key TEXT             Your Coinbase Advanced Trade API key
+  --coinbase-api-secret TEXT          Your Coinbase Advanced Trade API secret
   --binance-exchange-name [Binance|BinanceUS|Binance-USDM-Futures|Binance-COIN-Futures]
                                   Binance exchange name [Binance, BinanceUS, Binance-USDM-Futures, Binance-COIN-Futures]
   --binance-api-key TEXT          Your Binance API key
@@ -1052,9 +1049,9 @@ Options:
   --environment TEXT              The environment to use
   --output DIRECTORY              Directory to store results in (defaults to PROJECT/live/TIMESTAMP)
   -d, --detach                    Run the live deployment in a detached Docker container and return immediately
-  --brokerage [Paper Trading|Interactive Brokers|Tradier|Oanda|Bitfinex|Coinbase Pro|Binance|Zerodha|Samco|Terminal Link|Trading Technologies|Kraken|TDAmeritrade|Bybit]
+  --brokerage [Paper Trading|Interactive Brokers|Tradier|Oanda|Bitfinex|Coinbase Advanced Trade|Binance|Zerodha|Samco|Terminal Link|Trading Technologies|Kraken|TDAmeritrade|Bybit]
                                   The brokerage to use
-  --data-feed [Interactive Brokers|Tradier|Oanda|Bitfinex|Coinbase Pro|Binance|Zerodha|Samco|Terminal Link|Kraken|TDAmeritrade|IQFeed|Polygon|Custom data only|Bybit]
+  --data-feed [Interactive Brokers|Tradier|Oanda|Bitfinex|Coinbase Advanced Trade|Binance|Zerodha|Samco|Terminal Link|Kraken|TDAmeritrade|IQFeed|Polygon|Custom data only|Bybit]
                                   The data feed to use
   --data-provider [Polygon|QuantConnect|Local]
                                   Update the Lean configuration file to retrieve data from the given provider
@@ -1075,11 +1072,8 @@ Options:
                                   The environment to run in, Practice for fxTrade Practice, Trade for fxTrade
   --bitfinex-api-key TEXT         Your Bitfinex API key
   --bitfinex-api-secret TEXT      Your Bitfinex API secret
-  --gdax-api-key TEXT             Your Coinbase Pro API key
-  --gdax-api-secret TEXT          Your Coinbase Pro API secret
-  --gdax-passphrase TEXT          Your Coinbase Pro API passphrase
-  --gdax-use-sandbox [live|paper]
-                                  Whether the sandbox should be used
+  --coinbase-api-key TEXT             Your Coinbase Advanced Trade API key
+  --coinbase-api-secret TEXT          Your Coinbase Advanced Trade API secret
   --binance-exchange-name [Binance|BinanceUS|Binance-USDM-Futures|Binance-COIN-Futures]
                                   Binance exchange name [Binance, BinanceUS, Binance-USDM-Futures, Binance-COIN-Futures]
   --binance-api-key TEXT          Your Binance API key

diff --git a/tests/commands/cloud/live/test_cloud_live_commands.py b/tests/commands/cloud/live/test_cloud_live_commands.py
@@ -222,7 +222,7 @@ def test_cloud_live_deploy_with_notifications(notice_method: str, configs: str)
                                             ("Trading Technologies", "USD:100"),
                                             ("Binance", "USD:100"),
                                             ("Bitfinex", "USD:100"),
-                                            ("Coinbase Pro", "USD:100"),
+                                            ("Coinbase Advanced Trade", "USD:100"),
                                             ("Interactive Brokers", "USD:100"),
                                             ("Kraken", "USD:100"),
                                             ("OANDA", "USD:100"),
@@ -290,8 +290,8 @@ def test_cloud_live_deploy_with_live_cash_balance(brokerage: str, cash: str) ->
                                                 ("Binance", "A:A 2T:1:145.1"),
                                                 ("Bitfinex", ""),
                                                 ("Bitfinex", "A:A 2T:1:145.1"),
-                                                ("Coinbase Pro", ""),
-                                                ("Coinbase Pro", "A:A 2T:1:145.1"),
+                                                ("Coinbase Advanced Trade", ""),
+                                                ("Coinbase Advanced Trade", "A:A 2T:1:145.1"),
                                                 ("Interactive Brokers", ""),
                                                 ("Interactive Brokers", "A:A 2T:1:145.1"),
                                                 ("Kraken", ""),

diff --git a/tests/commands/test_live.py b/tests/commands/test_live.py
@@ -292,11 +292,9 @@ def test_live_aborts_when_lean_config_is_missing_properties(target: str, replace
         "bitfinex-api-key": "123",
         "bitfinex-api-secret": "456",
     },
-    "Coinbase Pro": {
-        "gdax-api-key": "123",
-        "gdax-api-secret": "456",
-        "gdax-passphrase": "789",
-        "gdax-use-sandbox": "paper"
+    "Coinbase Advanced Trade": {
+        "coinbase-api-key": "123",
+        "coinbase-api-secret": "456",
     },
     "Binance": {
         "binance-exchange-name": "binance",
@@ -366,7 +364,7 @@ def test_live_aborts_when_lean_config_is_missing_properties(target: str, replace
     "Tradier": brokerage_required_options["Tradier"],
     "OANDA": brokerage_required_options["OANDA"],
     "Bitfinex": brokerage_required_options["Bitfinex"],
-    "Coinbase Pro": brokerage_required_options["Coinbase Pro"],
+    "Coinbase Advanced Trade": brokerage_required_options["Coinbase Advanced Trade"],
     "Binance": brokerage_required_options["Binance"],
     "Zerodha": brokerage_required_options["Zerodha"],
     "Samco": brokerage_required_options["Samco"],
@@ -853,8 +851,8 @@ def test_live_passes_custom_python_venv_to_lean_runner_when_given_as_option(pyth
                                             ("Binance", "USD:100"),
                                             ("Bitfinex", ""),
                                             ("Bitfinex", "USD:100"),
-                                            ("Coinbase Pro", ""),
-                                            ("Coinbase Pro", "USD:100"),
+                                            ("Coinbase Advanced Trade", ""),
+                                            ("Coinbase Advanced Trade", "USD:100"),
                                             ("Interactive Brokers", ""),
                                             ("Interactive Brokers", "USD:100"),
                                             ("Kraken", ""),
@@ -917,8 +915,8 @@ def test_live_passes_live_cash_balance_to_lean_runner_when_given_as_option(broke
                                                 ("Binance", "A:A 2T:1:145.1"),
                                                 ("Bitfinex", ""),
                                                 ("Bitfinex", "A:A 2T:1:145.1"),
-                                                ("Coinbase Pro", ""),
-                                                ("Coinbase Pro", "A:A 2T:1:145.1"),
+                                                ("Coinbase Advanced Trade", ""),
+                                                ("Coinbase Advanced Trade", "A:A 2T:1:145.1"),
                                                 ("Interactive Brokers", ""),
                                                 ("Interactive Brokers", "A:A 2T:1:145.1"),
                                                 ("Kraken", ""),

diff --git a/tests/components/api/test_clients.py b/tests/components/api/test_clients.py
@@ -305,11 +305,11 @@ def test_data_client_list_files() -> None:
     data_client = DataClient(api_client, HTTPClient(mock.Mock()))
 
     # Test files can be listed
-    files = data_client.list_files("crypto/gdax/daily/")
+    files = data_client.list_files("crypto/coinbase/daily/")
 
     # Test all files start with the requested prefix
     for file in files:
-        assert file.startswith("crypto/gdax/daily/")
+        assert file.startswith("crypto/coinbase/daily/")
 
 
 def test_data_client_get_info() -> None: