Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: new generic LongFromZeroUpdateAndCancel test for Brokerages #8545

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Jan 21, 2025

Description

Sometimes, we need to test which will not be filled to prevent the loss of cash. To prevent this, the PR has a specific test that helps test the UpdateFunctional without extra payment.
image

Related Issue

N/a

Motivation and Context

Create test which help to test UpdateFunctional without extra payment.

Requires Documentation Change

N/a

How Has This Been Tested?

Run new test in brokerage.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes self-assigned this Jan 21, 2025
@Romazes Romazes merged commit 8330dd9 into QuantConnect:master Jan 21, 2025
6 of 7 checks passed
@Romazes Romazes deleted the feature-place-update-cancel-generic-brokerage-test branch January 21, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants