Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Initialize class BrokerageDataDownloader with Global configs. #8482

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Dec 26, 2024

Description

We hit the bug in brokerage/data provider when we run backtest or research any command, excluding live mode. We don't pass global configurations to our brokerage/data provider.

Related Issue

N/a

Motivation and Context

Fix this bug so the next developer can use the config explicitly with class LiveNodePacket.

Requires Documentation Change

N/A

How Has This Been Tested?

run commands with using lean-cli:

  • lean data download ...
  • lean research CharlesSchwabLiveAlgo2 --data-provider-historical CharlesSchwab --verbose
  • lean live deploy CharlesSchwabLiveAlgo2 --verbose
  • lean backtest CharlesSchwabLiveAlgo2 --data-provider-historical CharlesSchwab --verbose

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit eca4f5b into QuantConnect:master Dec 26, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants