Fix: Initialize class BrokerageDataDownloader
with Global configs.
#8482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We hit the bug in brokerage/data provider when we run
backtest
orresearch
any command, excluding live mode. We don't pass global configurations to our brokerage/data provider.Related Issue
N/a
Motivation and Context
Fix this bug so the next developer can use the config explicitly with
class LiveNodePacket
.Requires Documentation Change
N/A
How Has This Been Tested?
run commands with using lean-cli:
lean data download ...
lean research CharlesSchwabLiveAlgo2 --data-provider-historical CharlesSchwab --verbose
lean live deploy CharlesSchwabLiveAlgo2 --verbose
lean backtest CharlesSchwabLiveAlgo2 --data-provider-historical CharlesSchwab --verbose
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>