-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SqueezeMomentum (SM) indicator #8462
Implement SqueezeMomentum (SM) indicator #8462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! Leaving a few minor comments
Pending: Confirm which implementation of Keltner Channels is correct: using typical price (average of open, high, close) like Lean's |
@jhonabreul The python script was updated:
And here are the references: |
- Make the Bollinger Bands and Keltner Channels indicators public. - In IndicatorBase -> Update, if T is IndicatorDataPoint, then create a new IndicatorDataPoint.
861c2a4
to
87bb775
Compare
87bb775
to
5c4eb42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Description
This pull request introduces the Squeeze Momentum Indicator (SM), which combines the Bollinger Bands and Keltner Channels to identify periods of low volatility in the market, signaling potential future price movements. The indicator highlights when the market is "squeezed" and a breakout may be imminent
Related Issue
Closes #4166
Motivation and Context
The Squeeze Momentum Indicator is important for traders who wish to identify periods of consolidation in the market. By identifying when volatility is low, it helps to predict possible breakouts, enhancing decision-making for entry and exit points.
Requires Documentation Change
Yes, the documentation should be updated to include usage instructions for the Squeeze Momentum Indicator and explain its parameters.
How Has This Been Tested?
The Squeeze Momentum Indicator has been tested using historical data from the SPY and compared against values generated using the Talib library.
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>