Implement ZigZag (ZZ) indicator #8454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonabreul
reviewed
Dec 11, 2024
JosueNina
force-pushed
the
feature-3179-zig-zag-indicator
branch
from
00f96dd to
1e9f82e
Compare
…ature-3179-zig-zag-indicator
- Refactored logic to streamline pivot updates and condition checks. - Exposed PivotType enum to track pivot direction (High/Low). - Updated CSV processing to reflect pivot type (High/Low).
…ature-3179-zig-zag-indicator
JosueNina
force-pushed
the
feature-3179-zig-zag-indicator
branch
from
934a25f to
1e8908f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the ZigZag indicator, which is used to identify significant price movements and trends by connecting key high and low points in a financial time series. It helps traders and analysts visualize trend changes and potential reversals in the market.
Related Issue
Closes #3179
Motivation and Context
The ZigZag indicator is useful for detecting trend changes and filtering out market noise, which can improve technical analysis by focusing on significant price movements.
Requires Documentation Change
Yes, the documentation should be updated to include usage instructions for the ZigZag indicator and explain the parameters such as sensitivity and minimum trend length.
How Has This Been Tested?
The ZigZag indicator has been tested using unit tests that verify the calculation of the indicator over historical data. The Talipp library was used to compare values and ensure the accuracy of the indicator's output against expected results.
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>