Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Global Configs #10

Merged

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Feb 21, 2024

Description

Related Issue

N/A

Motivation and Context

Maintain a uniform code format like in others repos.

Requires Documentation Change

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Contributor

@jhonabreul jhonabreul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Leaving some comments

QuantConnect.Polygon.Tests/PolygonDataDownloaderTests.cs Outdated Show resolved Hide resolved
QuantConnect.Polygon.Tests/PolygonHistoryTests.cs Outdated Show resolved Hide resolved
QuantConnect.Polygon/PolygonDataDownloader.cs Outdated Show resolved Hide resolved
QuantConnect.Polygon/PolygonDataDownloader.cs Outdated Show resolved Hide resolved
QuantConnect.Polygon/PolygonDataDownloader.cs Outdated Show resolved Hide resolved
QuantConnect.Polygon/PolygonDataDownloader.cs Outdated Show resolved Hide resolved
QuantConnect.Polygon/PolygonDataDownloader.cs Show resolved Hide resolved
QuantConnect.Polygon/PolygonDataProvider.cs Show resolved Hide resolved
@Romazes Romazes requested a review from jhonabreul February 26, 2024 14:04
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit e0a3180 into QuantConnect:master Feb 27, 2024
@Romazes Romazes deleted the feature-replace-config-to-globals branch February 28, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants