-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new Global Configs #10
Merged
Martin-Molinero
merged 8 commits into
QuantConnect:master
from
Romazes:feature-replace-config-to-globals
Feb 27, 2024
Merged
Use new Global Configs #10
Martin-Molinero
merged 8 commits into
QuantConnect:master
from
Romazes:feature-replace-config-to-globals
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove: validation of ApiKey in GetHistory()
refactor: test with support null
jhonabreul
requested changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Leaving some comments
rename: several methods fix: return empty result if data is wrong
jhonabreul
approved these changes
Feb 26, 2024
Martin-Molinero
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows Consolidate Configuration.Get usages Lean#7796
GetHistory()
. It is checked in initialize method.Related Issue
N/A
Motivation and Context
Maintain a uniform code format like in others repos.
Requires Documentation Change
N/A
How Has This Been Tested?
N/A
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>