Dotnet 9 (#50)

QuantConnect · Dec 19, 2024 · adb67b6 · adb67b6
1 parent 75a4b20
commit adb67b6
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 22 deletions.
diff --git a/.github/workflows/gh-actions.yml b/.github/workflows/gh-actions.yml
@@ -6,17 +6,18 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
-    env:
-        KRAKEN_PUBLIC: ${{ secrets.KRAKEN_PUBLIC }}
-        KRAKEN_PRIVATE: ${{ secrets.KRAKEN_PRIVATE }}
-        QC_JOB_USER_ID: ${{ secrets.JOB_USER_ID }}
-        QC_API_ACCESS_TOKEN: ${{ secrets.API_ACCESS_TOKEN }}
-        QC_JOB_ORGANIZATION_ID: ${{ secrets.JOB_ORGANIZATION_ID }}
-    container:
-        image: quantconnect/lean:foundation
+    runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Liberate disk space
+        uses: jlumbroso/free-disk-space@main
+        with:
+          tool-cache: true
+          large-packages: false
+          docker-images: false
+          swap-storage: false
 
       - name: Checkout Lean Same Branch
         id: lean-same-branch
@@ -37,8 +38,13 @@ jobs:
       - name: Move Lean
         run: mv Lean ../Lean
 
-      - name: Build
-        run: dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 QuantConnect.KrakenBrokerage.sln
-
-      - name: Run Tests
-        run: dotnet test ./QuantConnect.KrakenBrokerage.Tests/bin/Release/QuantConnect.KrakenBrokerage.Tests.dll
+      - uses: addnab/docker-run-action@v3
+        with:
+          image: quantconnect/lean:foundation
+          options: --workdir /__w/Lean.Brokerages.Kraken/Lean.Brokerages.Kraken -v /home/runner/work:/__w -e KRAKEN_PUBLIC=${{ secrets.KRAKEN_PUBLIC }} -e KRAKEN_PRIVATE=${{ secrets.KRAKEN_PRIVATE }} -e QC_JOB_USER_ID=${{ secrets.JOB_USER_ID }} -e QC_API_ACCESS_TOKEN=${{ secrets.API_ACCESS_TOKEN }} -e QC_JOB_ORGANIZATION_ID=${{ secrets.JOB_ORGANIZATION_ID }} 
+          shell: bash
+          run: |
+            # Build
+            dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 QuantConnect.KrakenBrokerage.sln && \
+            # Run Tests
+            dotnet test ./QuantConnect.KrakenBrokerage.Tests/bin/Release/QuantConnect.KrakenBrokerage.Tests.dll
diff --git a/QuantConnect.KrakenBrokerage.Tests/KrakenBrokerageTests.cs b/QuantConnect.KrakenBrokerage.Tests/KrakenBrokerageTests.cs
@@ -48,7 +48,7 @@ protected override IBrokerage CreateBrokerage(IOrderProvider orderProvider, ISec
 
             var securities = new SecurityManager(new TimeKeeper(DateTime.UtcNow, TimeZones.NewYork))
             {
-                {Symbol, CreateSecurity(Symbol)}
+                {Symbol, SecurityProvider.GetSecurity(Symbol)}
             };
             securities[Symbol].MarginModel = new SecurityMarginModel(leverage: Leverage);
 

diff --git a/QuantConnect.KrakenBrokerage.Tests/QuantConnect.KrakenBrokerage.Tests.csproj b/QuantConnect.KrakenBrokerage.Tests/QuantConnect.KrakenBrokerage.Tests.csproj
@@ -3,7 +3,7 @@
     <PropertyGroup>
         <Configuration Condition=" '$(Configuration)' == '' ">Release</Configuration>
         <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
 
         <IsPackable>false</IsPackable>
         <Copyright>Copyright ©  2021</Copyright>
@@ -18,13 +18,15 @@
 
     <ItemGroup>
         <PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
-        <PackageReference Include="NUnit" Version="3.13.3" />
-        <PackageReference Include="NUnit3TestAdapter" Version="4.2.1">
+        <PackageReference Include="NUnit" Version="4.2.2" />
+        <PackageReference Include="NUnit3TestAdapter" Version="4.6.0">
             <PrivateAssets>all</PrivateAssets>
-            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
     </ItemGroup>
+    <ItemGroup>
+        <Using Include="NUnit.Framework.Legacy.ClassicAssert" Alias="Assert" />
+    </ItemGroup>
 
     <ItemGroup>
       <ProjectReference Include="..\..\Lean\Tests\QuantConnect.Tests.csproj" />

diff --git a/QuantConnect.KrakenBrokerage.ToolBox/QuantConnect.KrakenBrokerage.ToolBox.csproj b/QuantConnect.KrakenBrokerage.ToolBox/QuantConnect.KrakenBrokerage.ToolBox.csproj
@@ -4,7 +4,7 @@
         <Configuration Condition=" '$(Configuration)' == '' ">Release</Configuration>
         <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
         <Copyright>Copyright ©  2021</Copyright>
         <OutputPath>bin\$(Configuration)\</OutputPath>
         <Product>QuantConnect.KrakenBrokerage.ToolBox</Product>

diff --git a/QuantConnect.KrakenBrokerage/QuantConnect.KrakenBrokerage.csproj b/QuantConnect.KrakenBrokerage/QuantConnect.KrakenBrokerage.csproj
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Release</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net9.0</TargetFramework>
     <Product>QuantConnect.KrakenBrokerage</Product>
     <RootNamespace>QuantConnect.KrakenBrokerage</RootNamespace>
     <AssemblyTitle>QuantConnect.KrakenBrokerage</AssemblyTitle>