Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: skip subscribe on Expired Option Symbol #121

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Aug 16, 2024

Description

Related Issue

Closes #118

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes self-assigned this Aug 16, 2024
@Romazes Romazes added the bug Something isn't working label Aug 16, 2024
Copy link
Collaborator

@jhonabreul jhonabreul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@Martin-Molinero Martin-Molinero merged commit f339040 into master Aug 19, 2024
1 check failed
@Martin-Molinero Martin-Molinero deleted the fix-118-not-subscribe-on-expired-options branch August 19, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do Not Subscribe to Expired Options After Weekly Restart
3 participants