Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing Algorithms / Trading and Orders / Order Management / Order Tickets Examples #1955

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Writing Algorithms / Trading and Orders / Order Management / Order Tickets Examples #1955

merged 3 commits into from
Nov 13, 2024

Conversation

LouisSzeto
Copy link
Collaborator

Description

  • Modify code snippets in the page to copyable full example
  • Add example usages

Related Issue

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • New feature (non-breaking change which adds functionality)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

AlexCatarino
AlexCatarino requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@AlexCatarino AlexCatarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @LouisSzeto.
I found a bug one algorithm.
Let's clarify what IsSucess means.

...ng Algorithms/22 Trading and Orders/02 Order Management/01 Order Tickets/03 Track Orders.php Outdated Show resolved Hide resolved
...g Algorithms/22 Trading and Orders/02 Order Management/01 Order Tickets/04 Update Orders.php Outdated Show resolved Hide resolved
...g Algorithms/22 Trading and Orders/02 Order Management/01 Order Tickets/04 Update Orders.php Outdated Show resolved Hide resolved
... Algorithms/22 Trading and Orders/02 Order Management/01 Order Tickets/05 Cancel Orders.html Outdated Show resolved Hide resolved
@AlexCatarino AlexCatarino merged commit c0a4077 into master Nov 13, 2024
@AlexCatarino AlexCatarino deleted the feature-order-tickets-examples branch November 13, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexCatarino AlexCatarino AlexCatarino requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LouisSzeto @AlexCatarino