Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freethreading support #19

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add freethreading support #19

merged 1 commit into from
Oct 17, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 16, 2024

No description provided.

amjames
amjames previously approved these changes Oct 17, 2024
Copy link
Member

@amjames amjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to either put this as a separate env template or maintain a new branch to allow folks to opt-in to this feature.

Go ahead and rebase for a start since I merged the #18 and LMK when this is ready/done

@amjames amjames dismissed their stale review October 17, 2024 21:41

Did not mean to approve yet, need to decide on the best way to keep this separate from the "normal" environment for now

@isuruf
Copy link
Member Author

isuruf commented Oct 17, 2024

I created a new env file so that we can keep this in the same branch.

@amjames amjames self-requested a review October 17, 2024 22:03
Copy link
Member

@amjames amjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amjames amjames merged commit 937327c into Quansight:main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants