-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MkDocs build #539
Fix MkDocs build #539
Conversation
980155e
to
25ff4e4
Compare
Avoiding a dirty index seems to solve the timestamp problem when installing on RTD. Now I'm getting a very strange error:
The line originally read Will continue to investigate Update: I figured it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks William, way better fix that what I suggested in #529 (comment). We have a mkdocs hook that shows the files and the respective diff that originates from RTD. However, that relies on git
to figure out the changes, which are no longer reported when we --assume-unchanged
. Could you add a post_install
RTD hook that effectively does git update-index --really-refresh
?
c.f. [this suggestion](Quansight#539 (comment))
dafa120
to
4c71146
Compare
f33f2aa
to
1ce849e
Compare
14a6bd7
to
b30177c
Compare
Partially addresses #529
This PR solves build failures on Read The Docs by telling git to ignore files that mkdocs/read the docs changes.
This PR does not solve the underlying issue with non-editable installs.
Preview the successfully built docs here