Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #506 : Fix value selector widget for IN and NOT_IN operator #512

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

pierrotsmnrd
Copy link
Contributor

Fix #506 : Fix value selector widget for IN and NOT_IN operator

This PR only fixes the UI issue with the vertical spacing. I was not able to reproduce the second problem. Let me know if it still occurs.

@pierrotsmnrd pierrotsmnrd requested a review from pmeier December 11, 2024 10:34
@pierrotsmnrd pierrotsmnrd changed the base branch from main to corpus-dev December 11, 2024 10:35
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I see on Firefox and Chromium respectively

image

image

which looks like it was before.

I also still see the second issue reported in #506. Can you share the process of what you did that wasn't able to reproduce it?

@pierrotsmnrd
Copy link
Contributor Author

I've pushed a fix. If you still see the issue, make sure you reload the page without cache.

Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre!

@pmeier pmeier merged commit fbb071b into corpus-dev Dec 20, 2024
9 of 10 checks passed
@pmeier pmeier deleted the fix-506 branch December 20, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix value selector widget for IN and NOT_IN operator
2 participants