use backend engine in UI #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error occurred while trying to automatically change base from
document-engine
to
deploy-dev
July 9, 2024 15:09
blakerosenthal
approved these changes
Jul 10, 2024
Absolutely. See me top comment for the state of the UI code. I've partially fixed the UI tests after your review. I'll finish them after auth is properly implemented. |
This was referenced Aug 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #441 and closes #392, closes #406. This leaves our UI code in a hot mess. But I thought for reviewing it will be easier to just drop in the engine where we previously used the API instead of starting yet another larger refactoring. However, this has to happen eventually and after this PR I'd prefer sooner than later.
After this PR we only have the auth rework left, that I need to finish before we can publish a first release of
bokeh-fastapi. Meaning, unless you have some hard blocking comments, I'd prefer to leave larger stuff for follow-up PRs. If you find something, flag it and I'll put up an issue.