Skip to content

Commit

Permalink
pin pymupdf to latest release (#169)
Browse files Browse the repository at this point in the history
  • Loading branch information
pmeier authored Nov 7, 2023
1 parent 3d8541f commit 6209845
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 20 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ all = [
"chromadb>=0.4.13",
"lancedb>=0.2",
"pyarrow",
"pymupdf",
"pymupdf>=1.23.6",
"tiktoken",
]

Expand Down
8 changes: 1 addition & 7 deletions ragna/core/_document.py
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,7 @@ class PdfDocumentHandler(DocumentHandler):

@classmethod
def requirements(cls) -> list[Requirement]:
return [
PackageRequirement(
"pymupdf",
# See https://github.com/Quansight/ragna/issues/75
exclude_modules=["fitz_new"],
)
]
return [PackageRequirement("pymupdf>=1.23.6")]

@classmethod
def supported_suffixes(cls) -> list[str]:
Expand Down
12 changes: 0 additions & 12 deletions tests/test_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
remove the offending test after you have cleaned up our code.
"""

import subprocess
import sys

import pytest

Expand All @@ -20,13 +18,3 @@ def test_pyarrow_dummy_module():
if "pyarrow" in distribution_names
}
assert "__dummy__" not in module_names


@pytest.mark.xfail
def test_pymupdf_import_warning():
# See https://github.com/Quansight/ragna/issues/75
result = subprocess.run(
[sys.executable, "-c", "import fitz_new"], capture_output=True
)
assert not result.stdout
assert not result.stderr

0 comments on commit 6209845

Please sign in to comment.