Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Update pre-commit hooks #45

Merged
merged 9 commits into from
Mar 29, 2024
Merged

Conversation

trallard
Copy link
Member

As I was reviewing some PRs I noticed our pre-commit hooks needed an update and that some files (HTML) were not being linted/formated.

Included in this PR:

  • Update pre-commit hooks and configs in pyproject.toml
  • Run linter on all files
  • Updates docs

There are a lot of changes as I ran the linter, so the only files needing a check are pyproject.toml and .pre-commit-config.yaml

Copy link

github-actions bot commented Mar 27, 2024

PR Preview Action v1.2.0
🚀 Deployed preview to https://Quansight-Labs.github.io/accessible-pygments/pr-preview/pr-45/
on branch gh-pages at 2024-03-28 15:49 UTC

@Carreau
Copy link
Collaborator

Carreau commented Mar 27, 2024

Approved, but this might conflict with other so Maybe merge later as it will be easier to rebase this (and rerun the precomit hooks) than other way around.

@trallard
Copy link
Member Author

Good shout on the (not) merging. I added a do-not-merge label for now

@Carreau Carreau force-pushed the trallard/update-pre-commits branch from f4f4e3b to 79b07ec Compare March 28, 2024 15:49
@Carreau
Copy link
Collaborator

Carreau commented Mar 28, 2024

Rebased / fixed conflicts by regenerating the files.

@Carreau
Copy link
Collaborator

Carreau commented Mar 28, 2024

One thing I did not do was delete the tests/results/*.html, as it seem the new scripts don't create those, but create pngs with playwrite, should I delete them ?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@gabalafou
Copy link
Contributor

One thing I did not do was delete the tests/results/*.html, as it seem the new scripts don't create those, but create pngs with playwrite, should I delete them ?

#41 (merged) deletes the entire test/results directory, so I'm not sure why that's not a merge conflict with main

@Carreau
Copy link
Collaborator

Carreau commented Mar 29, 2024

All looks good, let's merge, I don't think it will conflicts with #33

@Carreau Carreau merged commit 1c300d9 into main Mar 29, 2024
6 checks passed
@Carreau Carreau deleted the trallard/update-pre-commits branch March 29, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💪🏾 Done
Development

Successfully merging this pull request may close these issues.

3 participants