-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessibility statement #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed - added some comments and suggestions, nothing too major
Agree - I propose we start this as a result of this initial testing phase.
💯 - this is completely acceptable and helps set clear expectations
+1 on this - do we want to use an email for this? if so which would be best?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong but it seems to me that the tl;dr of an accessibility statement for JupyterLab should be something like:
- It sucks (as in, JupyterLab has a lot of egregious accessibility barriers)
- But we care (we're actively working on it; here's a link to our roadmap)
- And here's how to contact us (if you have any questions or concerns or want to get involved)
Do we feel that this accessibility statement conveys the essence of what we want to convey?
A link to the roadmap?
Because of the grant and my own mental well being, I have had to keep my focus a bit narrowly on JupyterLab. For me that includes paying attention to anything upstream (Lumino, CodeMirror) but giving carefully limited attention to anything downstream (Notebook v7).
An accessibility statement for JupyterLab should go in the JupyterLab repo, no? Also I'm not as concerned about where the file lives as much as how to get to it. For example, I think if somebody visits the JupyterLab repo, they should be able to search the keyword "accessibility" and find a link to this statement on that page. |
Replying to non-inline comments!
We could group the headers differently, though, and still benefit from W3C's guidance. Like use the outline you mentioned as a base for three main sections and lower the hierarchy of the existing headers to be grouped under those, if you think that would help navigation. Edit: I added headers roughly like you described and reordered the sections according to that.
|
I would rather just redirect folks to jupyter/accessibility instead of personal emails
👍🏽 this sounds like a good approach Thanks for all the work here @isabela-pf |
Co-authored-by: Tania Allard <[email protected]>
I think this is almost ready for merge? correct me if wrong @isabela-pf |
@trallard I personally think this is clean enough to be merged. There's still some feedback I haven't addressed which is why I hadn't pushed for it. The core of the draft statement is here, though. |
The question on adding this to the JLab repo will be discussed in the upcoming a11y meeting. Apart from this - the PR looks good to merge, WDYT @isabela-pf ? |
I am okay merging this! I think there is a solid enough foundation to build upon here. |
docs/resources/statement.md
Outdated
|
||
JupyterLab is designed to be compatible with the following technologies: | ||
|
||
* Windows, macOS, iOS, Android; Firefox, Chrome, Safari, Chromium browsers (mobile and desktop). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krassowski said add Linux!
JupyterLab is not compatible with: | ||
|
||
* Internet Explorer, Edge; JAWS, NVDA, VoiceOver, Narrator, Orca screen readers; voice control technology. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krassowski said
- We are looking to support Edge
- Is it worth mentioning the things we want to support
|
||
JupyterLab's accessibility does not exist in isolation. JupyterLab inherits much from the many projects it is built upon and its accessibility conformance may impact projects built off of JupyterLab or its components. The accessibility of this ecosystem is interlinked, so conformance may need to be resolved at different levels in order to impact JupyterLab positively. | ||
|
||
#### Compatibility with browsers and assistive technology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonyfast says this might be better as a table! Sorting tech by os, browser, assistive tech, so on…
docs/resources/statement.md
Outdated
|
||
Please note that JupyterLab is an open-source project and that Jupyter accessibility contributors are a group defined on a voluntary basis. Like many other open-source projects, we cannot guarantee how long it may take to respond to and resolve an issue, though we do make an effort to do it as quickly as is possible with our resources. | ||
|
||
### Date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonyfast says this should be at the top. Note it's a living document.
This is a draft accessibility statement edited from the W3C Accessibility Statement Generator Tool. It only applies to JupyterLab.
Below are thoughts copied from quansight-labs/jupyter-a11y-mgmt #52.
Things I think we should add
From Make your website or app accessible and publish an accessibility statement - Gov.UK, there are a few things we need to do. I've added check boxes to the quote to show what I think is covered in the above draft.
With this and the other resources, I think we may want to add
What next
To move forward, I would like to know a few things.