Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement application emojis #123

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

QuantumToasted
Copy link
Contributor

@QuantumToasted QuantumToasted commented Aug 5, 2024

Description

Checklist

  • I discussed this PR with the maintainer(s) prior to opening it.
  • I read the contributing guidelines.
  • I tested the changes in this PR.

Left over from when extensions were going to be on ICurrentUser...
GET /applications/{application.id}/emojis returns the emojis under a nested "items" object instead of returning an array directly. oops
IOwnedEmoji as a name was chosen since it represents an emoji that is (potentially) *owned* by a guild or application. Alternatives considered included IDiscordEmoji, but that seemed way too vague and not very descriptive of its common properties.

Also, adjusted XML documentation to compensate for these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants