Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint module resolution errors #7

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

Quaffel
Copy link
Owner

@Quaffel Quaffel commented Mar 23, 2021

Fixes eslint module resolution errors that may occur when the project is opened using the provided .code-workspace file.
VS Code should now also prompts users to use the workspace version of TypeScript. This way, it is ensured that the TypeScript language server plugins are loaded as well (including the one responsible for generating proper es module definitions for scss files).

Resolves #6.

List of fixed issues:

  • eslint-resolver-webpack-plugin doesn't respect eslint's working directory. Issue has been described here.
  • Webpack runs into a similar issue when webpack's resolution mechanism is invoked by eslint (tsconfig.json)
  • Workspace's TypeScript version isn't used by default

@Quaffel Quaffel requested a review from LinkKF March 23, 2021 21:57
@Quaffel Quaffel merged commit 23cd50b into development Mar 24, 2021
@Quaffel Quaffel deleted the fix/eslint-module-resolution branch March 24, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint module resolution breaks if project is openend from root directory
2 participants