-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .hexa() method #237
Add .hexa() method #237
Conversation
we need this feature too, hope this will be merged soon. |
Hi, as I've said in other issues, this won't be merged as-is. It's a breaking change. Please add a new method, |
Hi @Qix- , I have made the changes as per your suggestion. Please help review the codes :-) |
Is there any new progress now? |
I'll get to this later today, was planning on doing it this morning but the Sorry for the delay, PR is fine now and I'll merge this and release as a minor in a few hours. |
Appreciate it @Qix- and completely understand - the colors.js affected a lot of people. It was also a good reminder too not take OSS maintainers for granted. Thanks again for all the work on this library! |
Sorry didn't catch something, alpha should always be returned from |
Thanks :) Published as |
Hey just wondering if |
Looks like it was a TypeScript & VSCode issues, all sorted. |
Yeah any typings (including DT) will need to be updated to reflect the new method. I don't maintain them here, sorry about that! |
Currently the
hex
converter simply ignores thealpha
value if the color is ofrgba
format. The PR resolves the issue.Related to Do we already have argb hex string converter