fix:can't switch sync mode when no snap-sync peer #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dindinw
reviewed
Dec 12, 2024
services/common/flags.go
Outdated
| @@ -686,6 +691,7 @@ func DefaultConfig(homeDir string) *config.Config { | |||
| SubmitNoSynced: false, | |||
| DevNextGDB: true, | |||
| GBTTimeOut: defaultGBTTimeout, | |||
| SnapTimeout: 300, | |||
There was a problem hiding this comment.
Better to add extra defaultSnapTimeout after line 43 : defaultGBTTimeout = 800
dindinw
reviewed
Dec 12, 2024
config/config.go
Outdated
| @@ -144,6 +144,8 @@ type Config struct { | |||
|
|
|||
| // TODO: It will soon be discarded in the near future | |||
| DevSnapSync bool `long:"devsnapsync" description:"Enable snap sync for P2P that only exist in development mode"` | |||
|
|
|||
| SnapTimeout int `long:"snaptimeout" description:"Unable to find a peer that supports snap-sync service for setting IBD timeout(seconds), it will switch to the normal sync method"` | |||
There was a problem hiding this comment.
SnapTimeout -> FindSnapSyncPeerTimeout
a better description, During the IBD phase, if no peer node with snap-sync service enabled is found after the timeout (seconds), the node will switch to using the normal sync method.
There was a problem hiding this comment.
or NoSnapSyncPeerTimeout is also OK for me
dindinw
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.