Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 and musllinux to main #997

Merged
merged 19 commits into from
Oct 10, 2023

Conversation

mtreinish
Copy link
Member

As part of the 0.13.2 release we added support for Python 3.12 and musllinux to rustworkx. However, these changes did not happen on main yet. This commit applies the necessary changes to the main branch for the 0.14.0 and future releases. Also to simplify the configuration of the cibuildwheel jobs this combines #753 into this PR so that the configuration is centralized in the pyproject.toml.

As part of the 0.13.2 release we added support for Python 3.12 and
musllinux to rustworkx. However, these changes did not happen on main
yet. This commit applies the necessary changes to the main branch for
the 0.14.0 and future releases. Also to simplify the configuration of
the cibuildwheel jobs this combines Qiskit#753 into this PR so that the
configuration is centralized in the pyproject.toml.
@coveralls
Copy link

coveralls commented Oct 6, 2023

Pull Request Test Coverage Report for Build 6469003135

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.492%

Totals Coverage Status
Change from base Build 6458330574: 0.0%
Covered Lines: 15431
Relevant Lines: 15992

💛 - Coveralls

@mtreinish mtreinish added this to the 0.14.0 milestone Oct 6, 2023
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might need to split the x86_64 and i686 jobs for Linux. i686 seems particularly more prone to error due to BLAS, so I think we should handle installation without BLAS separately

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to remove the trigger on push and it should be good to go

@mtreinish mtreinish added automerge Queue a approved PR for merging and removed on hold labels Oct 10, 2023
@mergify mergify bot merged commit 2062a1c into Qiskit:main Oct 10, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants