-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Qiskit Ecosystem theme #926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5650435174
💛 - Coveralls |
Eric-Arellano
changed the title
[wip] Upgrade to new Qiskit sphinx theme
[wip] Switch to Qiskit Ecosystem theme
Jul 18, 2023
mtreinish
added
the
stable-backport-potential
This PR or issue is potentially worth backporting for inclusion in a stable branch
label
Jul 24, 2023
Eric-Arellano
changed the title
[wip] Switch to Qiskit Ecosystem theme
Switch to Qiskit Ecosystem theme
Jul 24, 2023
mtreinish
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the docs look great with this new theme. Thanks for the hard work on improving the theme package and pushing the update here.
The only thing missing is a solution for #824 to really make the docs feel complete :)
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Upgrade to new Qiskit sphinx theme * Use ecosystem theme --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e9b9c12)
mergify bot
added a commit
that referenced
this pull request
Jul 25, 2023
* Upgrade to new Qiskit sphinx theme * Use ecosystem theme --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e9b9c12) Co-authored-by: Eric Arellano <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
raynelfss
pushed a commit
to raynelfss/rustworkx
that referenced
this pull request
Aug 10, 2023
* Upgrade to new Qiskit sphinx theme * Use ecosystem theme --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Queue a approved PR for merging
stable-backport-potential
This PR or issue is potentially worth backporting for inclusion in a stable branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new theme is based on top of Furo from pip's docs. It is more functional and modern than the old Pytorch theme. It's also designed for ecosystem projects, e.g. no top Qiskit nav bar.