Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to qiskit_sphinx_theme 1.12 #880

Merged
merged 2 commits into from
May 24, 2023

Conversation

Eric-Arellano
Copy link
Contributor

The 1.12 theme release is focused on stability, including fixing the Previous Releases future that previously didn't work for ecosystem projects. See https://github.com/Qiskit/qiskit_sphinx_theme/releases/tag/1.12.0rc1 for the changelog.

This also:

  • Allows admins to build docs by pressing a button in GitHub UI
  • Adds tox -e docs-clean

@@ -156,13 +156,9 @@
{{ js_tag(scriptfile) }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is updated with changes made in 1.12.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this override. It's now the same as qiskit_sphinx_theme.

@coveralls
Copy link

coveralls commented May 23, 2023

Pull Request Test Coverage Report for Build 5060825249

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 96.548%

Totals Coverage Status
Change from base Build 5008896426: 0.01%
Covered Lines: 14571
Relevant Lines: 15092

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, theme seems to be working locally as well. I will merge and see how it deploys

I hope this makes changing 1.13 a easier for both rustworkx and qiskit-sphinx-theme

@IvanIsCoding IvanIsCoding merged commit 09d5707 into Qiskit:main May 24, 2023
@Eric-Arellano Eric-Arellano deleted the upgrade-to-theme-12 branch May 24, 2023 02:22
IvanIsCoding pushed a commit to IvanIsCoding/rustworkx that referenced this pull request May 26, 2023
* Upgrade to qiskit_sphinx_theme 1.12

* Fix static path option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants