Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update priority-queue to 1.3.0 #740

Closed
wants to merge 1 commit into from

Conversation

vlvrd
Copy link

@vlvrd vlvrd commented Nov 11, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sergio Valverde seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vlvrd vlvrd force-pushed the vlvrd/priority-queue-update branch from ea119e5 to dcfc9b9 Compare November 11, 2022 21:22
@mtreinish
Copy link
Member

Thank you for opening a PR, unfortunately we won't be able to merge this right now. The new version of priority-queue requires a newer version of rust than our current MSRV (minimum supported Rust version) which is 1.56.1. We hit this same CI failure on #740 which was opened by dependabot after priority-queue was released. We can revisit using the newer version of priority-queue when we bump our MSRV. However, that'll likely be some time because we just recently bumped the version to 1.56 in #717 so we're unlikely to change it again in the short term.

I'm going to close this PR because of this, but please feel free to reopen this PR if I'm missing something or you feel there is more to discuss on this.

@mtreinish mtreinish closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants