🐛 Fix deprecated Loader.load_module()
#728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added a commit
to cda-tum/mqt-qcec
that referenced
this pull request
Nov 4, 2022
the errors were the result of an ImportWarning in rustworkx which pytest interprets as an error. See See Qiskit/rustworkx#728 Until that is fixed, this PR just ignores the corresponding warning. Signed-off-by: burgholzer <[email protected]>
|
I am pretty confident we copied this code from Qiskit/qiskit#5089 (so it does also impact Qiskit Terra). I'll let @mtreinish review it |
IvanIsCoding
added
the
stable-backport-potential
mtreinish
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Thanks for fixing this, I think this should do the trick and maintain compatibility with the new import API to avoid the warnings.
As @IvanIsCoding said I did just copy this from what I ended up doing in qiskit-terra. The warning has actually been reported in an issue on the qiskit already: Qiskit/qiskit#8853 and I had forgot to circle back and write a fix for it there. If you have the bandwidth would you mind push a similar PR to qiskit-terra to fix the same issue in its loader class (if not no worries).
|
Sure. I'll do that over the weekend 👍🏻 |
Pull Request Test Coverage Report for Build 3395316397
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
(cherry picked from commit 53f0e31)
mergify bot
added a commit
that referenced
this pull request
Nov 4, 2022
(cherry picked from commit 53f0e31) Co-authored-by: Lukas Burgholzer <[email protected]>
|
See Qiskit/qiskit#9078. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any package that imports
retworkx(such asqiskit-terra) underPython>=3.10currently raisesImportWarning: RetworkxLoader.exec_module() not found; falling back to load_module()Any system that uses
pytestand sets thefilterwarningsfeature toerrorwill fail loudly as a consequence of this (see, e.g., https://github.com/cda-tum/qcec/actions/runs/3394728729/jobs/5643660360#step:4:453).Loader.load_module()has been deprecated since Python 3.4 (https://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module) and starting with 3.10, Python has started to actually raise the aboveImportWarning.This PR works around this issue by providing (rather straight-forward) implementations of the required
Loader.create_module()andLoader.exec_module()methods. The fix is inspired by benjaminp/six#343.With this PR,
rustworkxand, in turn,qiskitcan be used without errors underPython>=3.10.