Fix wheel builds #212
Merged
Fix wheel builds #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the wheel builds. The jobs hadn't been updated in a while and have become stale. The github actions x86 (linux, mac, and windows) were still trying to build 35 wheel even though python 3.5 support was been dropped in Qiskit#196. Then the docker image used for the manylinux2010 build needed to be updated because the pinned version in cibuildwheel is failing yum because of the centos 6 eol, which has been fixed on the latest docker image.
|
I've run these changes in ci: #211 (which is this commit plus a dnm change enabling release jobs everywhere and disabling upload) and it fixes everything. |
Pull Request Test Coverage Report for Build 398375701
💛 - Coveralls |
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Dec 7, 2020
The linux wheels we publish to PyPI at release time are based on the manylinux1 [1] and manylinux2010 [2] packaging specifications. To build these wheels we use the manylinux2010 docker image [3] which is based on centos 6. Centos 6 recently went end of life and the yum repositories for it were deleted and an archive url for the yum repositories were added. However, until the latest manylinux2010 docker image, the images were configured to use the old url from when the distro was still supported by upstream. This causes issues when trying to setup a build [4] because yum will error early during the initial job setup. To fix this we need to ensure we're using the latest version of the manylinux 2010 docker image, we can either do this manually (as was done in Qiskit/rustworkx#212 and Qiskit/qiskit-aer#1066) or just update the cibuildwheel version we're using to the latest release 1.7.1 which bumped the pinned manylinux2010 docker image used to one with updated yum urls (see pypa/cibuildwheel#472). This commit bumps the cibuildwheel version to the latest release so that when it is time to release terra 0.17.0 the jobs will work as expected. [1] https://www.python.org/dev/peps/pep-0513/ [2] https://www.python.org/dev/peps/pep-0571/ [3] https://github.com/pypa/manylinux [4] pypa/manylinux#836
mergify bot
added a commit
to Qiskit/qiskit
that referenced
this pull request
Dec 9, 2020
* Bump cibuildwheel to latest version The linux wheels we publish to PyPI at release time are based on the manylinux1 [1] and manylinux2010 [2] packaging specifications. To build these wheels we use the manylinux2010 docker image [3] which is based on centos 6. Centos 6 recently went end of life and the yum repositories for it were deleted and an archive url for the yum repositories were added. However, until the latest manylinux2010 docker image, the images were configured to use the old url from when the distro was still supported by upstream. This causes issues when trying to setup a build [4] because yum will error early during the initial job setup. To fix this we need to ensure we're using the latest version of the manylinux 2010 docker image, we can either do this manually (as was done in Qiskit/rustworkx#212 and Qiskit/qiskit-aer#1066) or just update the cibuildwheel version we're using to the latest release 1.7.1 which bumped the pinned manylinux2010 docker image used to one with updated yum urls (see pypa/cibuildwheel#472). This commit bumps the cibuildwheel version to the latest release so that when it is time to release terra 0.17.0 the jobs will work as expected. [1] https://www.python.org/dev/peps/pep-0513/ [2] https://www.python.org/dev/peps/pep-0571/ [3] https://github.com/pypa/manylinux [4] pypa/manylinux#836 * DNM: test wheel jobs * Revert "DNM: test wheel jobs" This reverts commit b63071a. Co-authored-by: Kevin Krsulich <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the wheel builds. The jobs hadn't been updated in a
while and have become stale. The github actions x86 (linux, mac, and
windows) were still trying to build 35 wheel even though python 3.5
support was been dropped in #196. Then the docker image used for the
manylinux2010 build needed to be updated because the pinned version in
cibuildwheel is failing yum because of the centos 6 eol, which has been
fixed on the latest docker image.