Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused feature from sprs dependency #1299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IvanIsCoding
Copy link
Collaborator

In short, this disables the alga feature of the sprs crate. It is enabled by default and we don't use those traits, so the code still compiles and our tests still pass.

It also solves the annoying issue of having a older num-complex in Cargo.lock, because sometimes cargo update swaps the version we use which causes issues with PyO3 and ndarray/NumPy.

@IvanIsCoding IvanIsCoding added the dependencies Pull requests that update a dependency file label Oct 20, 2024
@coveralls
Copy link

coveralls commented Oct 20, 2024

Pull Request Test Coverage Report for Build 11429339267

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.835%

Totals Coverage Status
Change from base Build 11406566540: 0.0%
Covered Lines: 18018
Relevant Lines: 18801

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants