Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise MSRV to 1.56 #716

Closed
mtreinish opened this issue Oct 26, 2022 · 2 comments · Fixed by #717
Closed

Raise MSRV to 1.56 #716

mtreinish opened this issue Oct 26, 2022 · 2 comments · Fixed by #717

Comments

@mtreinish
Copy link
Member

What is the expected enhancement?

Right now our MSRV for rustworkx is 1.48 to match what the latest rust version that Debian stable ships. This was originally done to support the piwheels build environment which installs rustc via debian packages. However this causes a lot of development friction as our upstream dependencies typically adopt newer MSRVs much faster than debian bumps their MSRV. It also blocks us from using newer rust language features. When weighing that against the raspberry pi user base via piwheels is very small (607 all time downloads compared to our monthly pypi download rate of ~150k) and the rustworkx wheels failed to build so there hasn't been any downloads of it ye I think we should just pick an MSRV that suits our development needs more than trying to maintain compatibility for an unsupported platform.

I'd like to propose we bump the MSRV to 1.56.1. This is the version that adds rust edition 2021 and I think will enable us to use the latest versions of most of our upstream dependencies (it's also the MSRV that qiskit-terra picked for similar reasons).
mtreinish added a commit to mtreinish/retworkx that referenced this issue Oct 26, 2022
@mtreinish
Bump MSRV to 1.56.1 and update dependencies and Rust Edition
0930613 
The previous minimum support Rust version of 1.48 was originally
selected to match the latest version of Rust available through Debian
stable. This was done primarily to support the piwheels build
environemnt which installs rustc via Debian packages. However, the 1.48
MSRV is causing a lot development friction as it's quite old and is
holding back a lot of dependencies. When weighing the relatively tiny
piwheels user base (for an unsupported platform) against this it's
probably time to decouple our MSRV for rustworkx from that and pick a
version that makes the most sense for our development needs.

This commit raises the minimum supported rust version to 1.56.1 and then
bumps all our dependencies held back because of the previous MSRV. At
the same time the rust edition used for rustworkx is changed to be
edition 2021 instead of edition 2018. This will enable us to leverage
newer rust syntax now.

Fixes Qiskit#716
@mtreinish mtreinish mentioned this issue Oct 26, 2022
Merged
@IvanIsCoding
Copy link
Collaborator

I agree with bumping the Rust version.

I want to support the most platforms we possibly can (see #703 for example), but having this external constraint that we need to compile out of vanilla Debian is very restricting for keeping up with PyO3 and our other dependencies.

If piwheels had something like the custom builds like conda-forge does for us we could even contribute, but their build system is extremly unflexible. I'd rather build linux_armv6l and linux_armv7l wheels on our CI and publish them manually

@mtreinish
Copy link
Member Author

Well Pyo3 has the same msrv following debian policy (at the time I was in favor of it and one of the proponents for defining a pyo3 msrv policy). The extra complexity for pyo3 is that it's now used by cryptography which adds a whole layer of scale for usage that we don't ever have to worry about (like debian depends on cryptography for distro tooling written in Python). But it's definitely been a huge pain for other dependencies. The big one in my mind is ndarray which we've been on a really old version for a long time

@mergify mergify bot closed this as completed in #717 Oct 28, 2022
mergify bot pushed a commit that referenced this issue Oct 28, 2022
@mtreinish @IvanIsCoding
Bump MSRV to 1.56.1 and update dependencies and Rust Edition (#717)
70b7977 
The previous minimum support Rust version of 1.48 was originally
selected to match the latest version of Rust available through Debian
stable. This was done primarily to support the piwheels build
environemnt which installs rustc via Debian packages. However, the 1.48
MSRV is causing a lot development friction as it's quite old and is
holding back a lot of dependencies. When weighing the relatively tiny
piwheels user base (for an unsupported platform) against this it's
probably time to decouple our MSRV for rustworkx from that and pick a
version that makes the most sense for our development needs.

This commit raises the minimum supported rust version to 1.56.1 and then
bumps all our dependencies held back because of the previous MSRV. At
the same time the rust edition used for rustworkx is changed to be
edition 2021 instead of edition 2018. This will enable us to leverage
newer rust syntax now.

Fixes #716

Co-authored-by: Ivan Carvalho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump MSRV to 1.56.1 and update dependencies and Rust Edition mtreinish/retworkx
2 participants
@mtreinish @IvanIsCoding