Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert clickable title to Furo default and add ecosystem link under it #607

Merged
merged 11 commits into from
Jun 19, 2024
Merged

Revert clickable title to Furo default and add ecosystem link under it #607

merged 11 commits into from
Jun 19, 2024

Conversation

kevinsung
Copy link
Collaborator

@kevinsung kevinsung commented Jun 12, 2024 •
edited
Loading

Fixes #604

@kevinsung kevinsung force-pushed the fix-clickable-title branch 2 times, most recently from d614d79 to c6ca5ab Compare June 12, 2024 16:00
Eric-Arellano
Eric-Arellano reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it look with centering the title? I recommend posting in the qiskit ecosystem Slack channel a few options for people to consider:

  • left aligned
  • centered title, but left aligned Qiskit ecosystem text
  • centered title & ecosystem text

src/qiskit_sphinx_theme/theme/qiskit-sphinx-theme/custom_templates/sidebar_brand.html Show resolved Hide resolved
src/qiskit_sphinx_theme/theme/qiskit-sphinx-theme/custom_templates/sidebar_brand.html Outdated Show resolved Hide resolved
@kevinsung
Copy link
Collaborator Author

How does it look with centering the title? I recommend posting in the qiskit ecosystem Slack channel a few options for people to consider:

* left aligned

* centered title, but left aligned Qiskit ecosystem text

* centered title & ecosystem text

Done. Will update the screenshot diffs after we choose which option to take.

Eric-Arellano
Eric-Arellano reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I'll give final approval after checking the new screenshot.

src/qiskit_sphinx_theme/assets/styles/_left-sidebar.scss Show resolved Hide resolved
Eric-Arellano
Eric-Arellano approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kevinsung
Copy link
Collaborator Author

CI failures seem unrelated

@kevinsung kevinsung merged commit f7e512d into Qiskit:main Jun 19, 2024
3 checks passed
@kevinsung kevinsung deleted the fix-clickable-title branch June 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganize clickable title and ecosystem link
2 participants
@kevinsung @Eric-Arellano