Remove "was this page useful" mechanism (analytics) #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Nice!
I found the following remaining references to the analytics:
CONTRIBUTING.md
97:1. Find the "actual" snapshot for the failing test, such as `footer-includes-page-analytics-1-actual.png`.
src/qiskit_sphinx_theme/assets/styles/_footer.scss
14:.qiskit-analytics-container {
40:#qiskit-analytics-thank-you {
src/qiskit_sphinx_theme/ecosystem/page.html
108: {% include "custom_templates/footer_analytics.html" %}
tests/js/ecosystem.test.js
114: const yesOption = page.locator("div.qiskit-analytics-container a").first();
Should these be removed too?
…inx_theme into EA/rm-analytics
|
Yes. Good catch @frankharkins / pardon my oversight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qiskit documentation now lives in docs.quantum.ibm.com and has its own analytics mechanism.
The Qiskit Ecosystem projects will be migrating to GitHub pages. Qiskit/ecosystem#578. Given that, I doubt we'll want to commit to still maintaining this analytics mechanism. Maintenance is more than only the code: it also means committing to helping projects access the dashboard.
Instead, keep this Sphinx theme as simple as possible to make it more sustainable. Projects highly interested in analytics could always add the functionality their own way.