Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Qiskit logo #409

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

The only known place we're using this logo is for users to set up NBSphinx to use the logo as the icon for their tutorials gallery, which we introduced in Sphinx Theme 1.12 with #318.

As shown in the snapshot test, we also now use a bigger image, which takes up more of the tutorial box.

@javabster
Copy link
Collaborator

Um honestly I think I prefer the logo when it is smaller, it feels a bit too intense taking up basically the whole of the tutorial box, and now there is uneven spacing between the top/bottom and the left/right borders

@Eric-Arellano
Copy link
Collaborator Author

@javabster Russell sent me a new image. How is this? I personally like the icon being a little bigger like this.

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Eric-Arellano Eric-Arellano merged commit ddacd87 into Qiskit:main Jun 27, 2023
@Eric-Arellano Eric-Arellano deleted the EA/update-qiskit-icon branch June 27, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants