Add Furo to install_requires and bump Sphinx requirement to 6.0+ #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
changed the title
|
I realized that Sphinx 6 drops Python 3.7 support, which may break some projects' CI when they upgrade to Theme 1.13. I will bring this up at today's Qiskit Dev Meeting. On Hold for now. |
Eric-Arellano
changed the title
|
We realized in the Qiskit Dev meeting that this is safe to land. Even if some projects want to keep using Python 3.7 for their code, they all are okay with using 3.8+ to build the docs. To avoid breaking their requirements-dev.txt, we can use a conditional requirement on the docs requirements like |
coruscating
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #330.
While we might not be ready to fully switch all production users to Furo in Theme 1.13, we at least will have made enough progress that it is ready for them to try it out. We want to make that setup easier.
The main change that impacts us from the prior release (https://github.com/pradyunsg/furo/commits/2023.05.20) is that Furo now requires Sphinx 6.0+. Note that Sphinx 6 drops Python 3.7. Most Qiskit projects have already made this change, but not all yet. So we probably need to coordinate this PR with those projects.