Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed css for typing.overload functions #319

Merged
merged 2 commits into from
May 11, 2023

Conversation

javabster
Copy link
Collaborator

@javabster javabster commented May 11, 2023

fixes #183
fixes #21

I tested this as best I could running locally and validating the changes I made with the inspect tool in production. However I can't be 100% sure as our local build doesn't currently have methods that a) use the typing.overload decorator and b) use internal links in their arguments.

testing in the browser using the inspect tools on live https://qiskit.org/documentation/stubs/qiskit.circuit.QuantumCircuit.if_test.html#qiskit.circuit.QuantumCircuit.if_test
Screenshot 2023-05-11 at 2 34 41 PM

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! If you'd like, I'd be happy to improve our example docs today or tomorrow so that we can test this out.

@Eric-Arellano
Copy link
Collaborator

Huzzah! This fixes #322! Great work Abby!

Screenshot 2023-05-11 at 3 40 23 PM

@Eric-Arellano Eric-Arellano merged commit e8c3ae0 into Qiskit:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants