-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Call to Action directive to use chevron-right after dropping Pytorch #433
Milestone
Comments
Eric-Arellano
added a commit
that referenced
this issue
Jun 30, 2023
Closes #327. This uses an extremely similar style to Pytorch: ![pytorch-cats](https://github.com/Qiskit/qiskit_sphinx_theme/assets/14852634/8df4e519-b09d-4cac-ae88-23e2fa693a72) It's main change is using our color variables. The padding is also a little less intense. The icon implementation is awkward, but I couldn't figure out how to reuse the icon from `icons.html` easily because we still need to support Pytorch. So, I went with this implementation and opened #433 to improve it once we drop Pytorch.
This blocks the ecosystem because it blocks #487. We need to have the stroke color be |
Eric-Arellano
added a commit
that referenced
this issue
Apr 30, 2024
Closes #433. This is mainly to reduce tech debt. Note that the color changed to a darker purple. Our color palette in the Furo theme only has the darker color of purple available, so this is acceptable. The icon is also a little smaller. I didn't spend much time trying to get the original size because the new size seems fine and this custom directive is not widely used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For our call to action item, we need a right purple chevron:
I implemented that in ... by using a
url()
with an inline SVG, similar to how we do it in Pytorch.But we already define a chevron in HTML:
qiskit_sphinx_theme/src/qiskit_sphinx_theme/theme/qiskit-sphinx-theme/partials/icons.html
Lines 20 to 28 in 86535e3
We should reuse this icon and use CSS to style it, e.g. change the stroke color.
I only didn't do this because it would be too complex to have a split implementation in Furo vs. Pytorch.
The text was updated successfully, but these errors were encountered: