Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out our release policy - do we backport bug fixes? #214

Closed
Eric-Arellano opened this issue Mar 16, 2023 · 1 comment
Closed

Figure out our release policy - do we backport bug fixes? #214

Eric-Arellano opened this issue Mar 16, 2023 · 1 comment
Labels
discussion

Comments

@Eric-Arellano
Copy link
Collaborator

Right now, once we switch to a new minor version, we stop supporting the old minor version with new patch fixes. Should we start doing patch fixes?

I would feel more confident about cherry-picking patch fixes with #208 figured out. Without it, I think there's too much risk we unintentionally break something in the backport.
@Eric-Arellano Eric-Arellano mentioned this issue Mar 16, 2023
Merged
This was referenced Mar 28, 2023
Closed
Merged
@Eric-Arellano
Copy link
Collaborator Author

I don't think we need a formal policy because we can (for now at least) do this on a case-by-case basis.

For example, we cherry-picked the hotfix for the top nav bar breaking to 1.10 in #247.

The important thing is that we now have release branches so are able to do patch releases when we want.

I would feel more confident about cherry-picking patch fixes with #208 figured out. Without it, I think there's too much risk we unintentionally break something in the backport.

We will need to be careful to manually test our changes until we have automated testing.

Eric-Arellano added a commit that referenced this issue Apr 12, 2023
@Eric-Arellano
Update release instructions for release branches (#239)
a0f8ef7 
While we're not sure yet how much we want to backport bugfixes to prior
releases (#214), we
decided this week to at least start having release branches like `1.11`.

That allows us to keep improving the theme without worrying about
breaking prior release series. It also allows us to backport bug fixes
when we want to.

This PR updates CI to run for PRs and pushes to branches other than
`main`, such as to `1.11`. It also updates our release instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eric-Arellano