Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set version number to 0.24.0rc1 for first release candidate #9977

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Set version number to 0.24.0rc1 for first release candidate #9977

merged 1 commit into from
Apr 20, 2023

Conversation

mtreinish
Copy link
Member

Summary

For the 0.24.0 release we're going to push release candidates prior to the release to enable testing before we cut the final release. In preparation for tagging the first release candidate this commit updates the version string to indicate it's a release candidate. This commit should be what gets tagged as 0.24.0rc1.

Details and comments

@mtreinish mtreinish added on hold Can not fix yet Changelog: None Do not include in changelog labels Apr 17, 2023
@mtreinish mtreinish added this to the 0.24.0 milestone Apr 17, 2023
@mtreinish mtreinish requested a review from a team as a code owner April 17, 2023 17:06
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@mtreinish
Copy link
Member Author

Marking this as on hold until we're ready to tag the release candidate. When merged the commit from this PR should be what gets tagged as 0.24.0rc1

@coveralls
Copy link

coveralls commented Apr 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4756816470

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 85.942%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/vf2_layout.rs 1 86.44%
crates/qasm2/src/lex.rs 2 91.9%
crates/accelerate/src/sabre_swap/layer.rs 4 97.32%
Totals Coverage Status
Change from base Build 4755986374: 0.04%
Covered Lines: 71155
Relevant Lines: 82794
💛 - Coveralls

@mtreinish mtreinish removed the on hold Can not fix yet label Apr 20, 2023
@mtreinish
Copy link
Member Author

mtreinish commented Apr 20, 2023 •
edited
Loading

Ok, this should be ready now that the release notes for rc1 have been finalized. This should be good to merge and then tag 0.24.0rc1 after:

both merge

@mtreinish
Set version number to 0.24.0rc1 for first release candidate
aef915e 
For the 0.24.0 release we're going to push release candidates
prior to the release to enable testing before we cut the final release.
In preparation for tagging the first release candidate this commit
updates the version string to indicate it's a release candidate. This
commit should be what gets tagged as 0.24.0rc1.
kevinhartman
kevinhartman approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtreinish mtreinish added this pull request to the merge queue Apr 20, 2023
Merged via the queue into Qiskit:main with commit 4152009 Apr 20, 2023
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
@mtreinish @king-p3nguin
Set version number to 0.24.0rc1 for first release candidate (Qiskit#9977
b16877b 
)

For the 0.24.0 release we're going to push release candidates
prior to the release to enable testing before we cut the final release.
In preparation for tagging the first release candidate this commit
updates the version string to indicate it's a release candidate. This
commit should be what gets tagged as 0.24.0rc1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinhartman kevinhartman kevinhartman approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mtreinish @qiskit-bot @coveralls @kevinhartman