Add HAS_PYGMENTS lazy tester
#9944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
the
Changelog: New Feature
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
This somehow slipped through my nets when I added all the lazy testers. We hope to drop support for the custom Pygments lexers in the future, but in the mean time, this is the correct way to test for things, and having an extra lazy tester doesn't hurt us.
jakelishman
force-pushed
the
has-pygments
branch
from
14a29de
to
56921c2
Compare
Pull Request Test Coverage Report for Build 5489481952
💛 - Coveralls |
mtreinish
previously approved these changes
Jul 5, 2023
mtreinish
approved these changes
Jul 10, 2023
ElePT
pushed a commit
to ElePT/qiskit-algorithms
that referenced
this pull request
Jul 27, 2023
* Add `HAS_PYGMENTS` lazy tester This somehow slipped through my nets when I added all the lazy testers. We hope to drop support for the custom Pygments lexers in the future, but in the mean time, this is the correct way to test for things, and having an extra lazy tester doesn't hurt us. * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This somehow slipped through my nets when I added all the lazy testers. We hope to drop support for the custom Pygments lexers in the future, but in the mean time, this is the correct way to test for things, and having an extra lazy tester doesn't hurt us.
Details and comments
Part of preparing to remove the built-in OpenQASM 2 Pygments tooling (and the
qiskit.qasmpackage as a whole).