AdaptVQE threshold improvements
#9921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
added
Changelog: New Feature
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
woodsp-ibm
reviewed
Apr 6, 2023
Cryoris
reviewed
Apr 6, 2023
Pull Request Test Coverage Report for Build 4689430083
💛 - Coveralls |
woodsp-ibm
reviewed
Apr 7, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Julien Gacon <[email protected]>
mrossinek
force-pushed
the
adapt-vqe-thresholds
branch
from
6ae4eb8
to
1a2a38f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Cryoris
approved these changes
Apr 14, 2023
giacomoRanieri
pushed a commit
to giacomoRanieri/qiskit-terra
that referenced
this pull request
Apr 16, 2023
* Pending-deprecate AdaptVQE.threshold in favor of gradient_threshold * Adds the AdaptVQE.eigenvalue_threshold attribute * Add release note * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Leverage deprecate_func on AdaptVQE.threshold property * Test pending deprecation of AdaptVQE.threshold * Add missing deprecate_func decorator to property setter * Improve documentation of AdaptVQE.eigenvalue_threshold w.r.t. final iteration * Adds a unittest for SparsePauliOp support in AdaptVQE * Attempt to fix test flakiness * Pick better operator pool for gradients in flaky unittest --------- Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: ElePT <[email protected]>
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* Pending-deprecate AdaptVQE.threshold in favor of gradient_threshold * Adds the AdaptVQE.eigenvalue_threshold attribute * Add release note * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Leverage deprecate_func on AdaptVQE.threshold property * Test pending deprecation of AdaptVQE.threshold * Add missing deprecate_func decorator to property setter * Improve documentation of AdaptVQE.eigenvalue_threshold w.r.t. final iteration * Adds a unittest for SparsePauliOp support in AdaptVQE * Attempt to fix test flakiness * Pick better operator pool for gradients in flaky unittest --------- Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: ElePT <[email protected]>
ElePT
added a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Pending-deprecate AdaptVQE.threshold in favor of gradient_threshold * Adds the AdaptVQE.eigenvalue_threshold attribute * Add release note * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Leverage deprecate_func on AdaptVQE.threshold property * Test pending deprecation of AdaptVQE.threshold * Add missing deprecate_func decorator to property setter * Improve documentation of AdaptVQE.eigenvalue_threshold w.r.t. final iteration * Adds a unittest for SparsePauliOp support in AdaptVQE * Attempt to fix test flakiness * Pick better operator pool for gradients in flaky unittest --------- Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: ElePT <[email protected]>
ElePT
added a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Pending-deprecate AdaptVQE.threshold in favor of gradient_threshold * Adds the AdaptVQE.eigenvalue_threshold attribute * Add release note * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Leverage deprecate_func on AdaptVQE.threshold property * Test pending deprecation of AdaptVQE.threshold * Add missing deprecate_func decorator to property setter * Improve documentation of AdaptVQE.eigenvalue_threshold w.r.t. final iteration * Adds a unittest for SparsePauliOp support in AdaptVQE * Attempt to fix test flakiness * Pick better operator pool for gradients in flaky unittest --------- Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: ElePT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
eigenvalue_thresholdsetting to theAdaptVQEwhich allows a more fine-tuned control of the convergence based on a minimal change of the eigenvalue with respect to an increasing ansatzthresholdattribute of theAdaptVQEto be calledgradient_thresholdin order to disambiguate it from the other (new) threshold mentioned above (using the old attribute will now log aPendingDeprecationWarning)Details and comments