-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdaptVQE
threshold improvements
#9921
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments below, otherwise the approach LGTM 👍🏻
Pull Request Test Coverage Report for Build 4689430083
💛 - Coveralls |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Julien Gacon <[email protected]>
6ae4eb8
to
1a2a38f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
* Pending-deprecate AdaptVQE.threshold in favor of gradient_threshold * Adds the AdaptVQE.eigenvalue_threshold attribute * Add release note * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Leverage deprecate_func on AdaptVQE.threshold property * Test pending deprecation of AdaptVQE.threshold * Add missing deprecate_func decorator to property setter * Improve documentation of AdaptVQE.eigenvalue_threshold w.r.t. final iteration * Adds a unittest for SparsePauliOp support in AdaptVQE * Attempt to fix test flakiness * Pick better operator pool for gradients in flaky unittest --------- Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: ElePT <[email protected]>
* Pending-deprecate AdaptVQE.threshold in favor of gradient_threshold * Adds the AdaptVQE.eigenvalue_threshold attribute * Add release note * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Leverage deprecate_func on AdaptVQE.threshold property * Test pending deprecation of AdaptVQE.threshold * Add missing deprecate_func decorator to property setter * Improve documentation of AdaptVQE.eigenvalue_threshold w.r.t. final iteration * Adds a unittest for SparsePauliOp support in AdaptVQE * Attempt to fix test flakiness * Pick better operator pool for gradients in flaky unittest --------- Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: ElePT <[email protected]>
* Pending-deprecate AdaptVQE.threshold in favor of gradient_threshold * Adds the AdaptVQE.eigenvalue_threshold attribute * Add release note * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Leverage deprecate_func on AdaptVQE.threshold property * Test pending deprecation of AdaptVQE.threshold * Add missing deprecate_func decorator to property setter * Improve documentation of AdaptVQE.eigenvalue_threshold w.r.t. final iteration * Adds a unittest for SparsePauliOp support in AdaptVQE * Attempt to fix test flakiness * Pick better operator pool for gradients in flaky unittest --------- Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: ElePT <[email protected]>
* Pending-deprecate AdaptVQE.threshold in favor of gradient_threshold * Adds the AdaptVQE.eigenvalue_threshold attribute * Add release note * Apply suggestions from code review Co-authored-by: Julien Gacon <[email protected]> * Leverage deprecate_func on AdaptVQE.threshold property * Test pending deprecation of AdaptVQE.threshold * Add missing deprecate_func decorator to property setter * Improve documentation of AdaptVQE.eigenvalue_threshold w.r.t. final iteration * Adds a unittest for SparsePauliOp support in AdaptVQE * Attempt to fix test flakiness * Pick better operator pool for gradients in flaky unittest --------- Co-authored-by: Julien Gacon <[email protected]> Co-authored-by: ElePT <[email protected]>
Summary
eigenvalue_threshold
setting to theAdaptVQE
which allows a more fine-tuned control of the convergence based on a minimal change of the eigenvalue with respect to an increasing ansatzthreshold
attribute of theAdaptVQE
to be calledgradient_threshold
in order to disambiguate it from the other (new) threshold mentioned above (using the old attribute will now log aPendingDeprecationWarning
)Details and comments